fix(nuxi): keep cwd at project root during preview#1235
Open
Davidson3556 wants to merge 3 commits intonuxt:mainfrom
Open
fix(nuxi): keep cwd at project root during preview#1235Davidson3556 wants to merge 3 commits intonuxt:mainfrom
Davidson3556 wants to merge 3 commits intonuxt:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#34397
📚 Description
nuxt previewwas spawning the server withcwdset to the.outputdirectory,which means
process.cwd()inside server handlers returns.outputinstead ofthe project root. This is inconsistent with running
node .output/server/index.mjsdirectly, which keeps the cwd at project root.
The fix keeps
cwdas the project root when spawning the preview server, andresolves the server entrypoint args to absolute paths using
outputPathso theywork without needing a chdir.